TPT-4443: Fix flaky tests#698
Open
mawilk90 wants to merge 4 commits into
Open
Conversation
mawilk90
force-pushed
the
hotfix/flaky_tests_fixes
branch
from
23089eb to
203479b
Compare
mawilk90
added
testing
mawilk90
force-pushed
the
hotfix/flaky_tests_fixes
branch
from
d35ffe8 to
abe5a53
Compare
mawilk90
requested review from
lgarber-akamai and
psnoch-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several integration tests to reduce flakiness by increasing polling timeouts and adding/standardizing explicit waits around eventually-consistent API behaviors (e.g., resource readiness and tag visibility).
Changes:
- Increased timeouts/intervals in multiple integration tests to better accommodate slower provisioning/migrations.
- Replaced ad-hoc try/except assertions with
pytest.raisesfor clearer, more consistent failure expectations. - Added targeted readiness polling (e.g., domain/volume “active”, Linode disks ready, tag creation visible) to reduce race conditions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/models/placement/test_placement.py | Increased migration request timeout to reduce flakiness. |
| test/integration/models/linode/test_linode.py | Increased rebuild “running” wait timeout. |
| test/integration/models/domain/test_domain.py | Increased post-clone sleep (but still uses fixed sleep). |
| test/integration/models/account/test_account.py | Increased wait parameters before reading latest events. |
| test/integration/linode_client/test_linode_client.py | Added wait_for_condition-based polling for disk/tag readiness; standardized error assertions with pytest.raises. |
| test/integration/conftest.py | Added waits to ensure created domain/volume reach “active” before use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Failing regression fixes
✔️ How to Test